Add expectContinueThresholdInBytes config to S3#6864
Open
alextwoods wants to merge 2 commits intomasterfrom
Open
Add expectContinueThresholdInBytes config to S3#6864alextwoods wants to merge 2 commits intomasterfrom
alextwoods wants to merge 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The
Expect: 100-continueheader allows a client to check whether the server will accept a request before sending the body. While this saves bandwidth on rejected requests, it adds a full round-trip of latency on every successful request. Benchmark data shows this overhead can increase latency by up to 30% for small uploads (under 1 MB) on public internet.Currently the SDK unconditionally adds the header to all
PutObjectandUploadPartrequests (whenexpectContinueEnabledis true). This change introduces a configurable content-length threshold so the header is skipped for small payloads where the cost outweighs the benefit.This is consistent with other AWS SDKs — JavaScript V3 and Kotlin both use a content-length threshold for this header.
Related to #6774 and #6828
Modifications
expectContinueThresholdInBytesconfiguration with default of 1MB.Testing
new + existing unit tests.
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License