Skip to content

[Tag] Add lAM policy to handle Tag updates on CW Logs during pcluster update-cluster#7267

Open
himani2411 wants to merge 6 commits intoaws:developfrom
himani2411:develop-tag-update
Open

[Tag] Add lAM policy to handle Tag updates on CW Logs during pcluster update-cluster#7267
himani2411 wants to merge 6 commits intoaws:developfrom
himani2411:develop-tag-update

Conversation

@himani2411
Copy link
Contributor

@himani2411 himani2411 commented Mar 5, 2026

Description of changes

autoscaling:DeleteTags
autoscaling:CreateOrUpdateTags
elasticloadbalancing:RemoveTags
elasticloadbalancing:ModifyTargetGroup
  • Updated tag propagation done using custom resource, where we add Tags to the Custom Resource Stack and the cluster-config and verify the existence once we update and override.

Tests

  • Integ test test

References

  • Link to impacted open issues.
  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch.
  • If you're creating a patch for a branch other than develop add the branch name as prefix in the PR title (e.g. [release-3.6]).
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@himani2411 himani2411 requested review from a team as code owners March 5, 2026 22:00
@himani2411 himani2411 added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Mar 5, 2026
@himani2411 himani2411 force-pushed the develop-tag-update branch 3 times, most recently from ab8c338 to 25e330a Compare March 6, 2026 23:47
- logs:DescribeMetricFilters
- logs:PutMetricFilter
- logs:deleteMetricFilter
- logs:ListTagsForResource
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE for reviewer: This already exist for tests/iam_policies/user-role.cfn.yaml

https://github.com/aws/aws-parallelcluster/blob/develop/tests/iam_policies/user-role.cfn.yaml#L495C18-L495C41

@himani2411 himani2411 force-pushed the develop-tag-update branch 2 times, most recently from aebeabf to 8a4a7d1 Compare March 7, 2026 01:10
@himani2411 himani2411 force-pushed the develop-tag-update branch from 8a4a7d1 to db6a3b1 Compare March 7, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x skip-changelog-update Disables the check that enforces changelog updates in PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant