[Logging] Add ISO 8601 timestamp with milliseconds precision to chef-client.log. #7175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarciani
force-pushed
the
wip/mgiacomo/3150/fix-cw-log-timestamp-1223-1
branch
from
7fd0ab1 to
ef4ca38
Compare
gmarciani
force-pushed
the
wip/mgiacomo/3150/fix-cw-log-timestamp-1223-1
branch
3 times, most recently
from
c88365b to
5f92b17
Compare
gmarciani
changed the title
gmarciani
force-pushed
the
wip/mgiacomo/3150/fix-cw-log-timestamp-1223-1
branch
from
5f92b17 to
4ead941
Compare
Contributor
Author
|
Closing this PR because we figured out that the custom log formatter does not apply the milliseconds timestamp to all log lines, ending up with some log lines having millis and some other having seconds, which messes up cw timestamp parsing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add ISO 8601 timestamp with milliseconds precision to chef-client.log.
This PR depends on aws/aws-parallelcluster-cookbook#3071, where the chef log formatter is introduced.
Tests
che-client.lognow has logs with millisecond precision:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.