Conversation
Collaborator
|
Changes LGTM, but how have them been tested? |
Contributor
Author
SA is testing it, I will let you know the result. |
15472c9 to
149c6f4
Compare
gmarciani
approved these changes
Oct 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changes
InGovCloudchecking the Partition equal toaws-us-govrather than check region equal tous-gov-west-1Tests
Manually test done. PCUI in gov-east (OSU) DID deploy successful, and it works well. Below is what we did:
parallelcluster-ui-cognito.yaml, specify the user email, create stack.cognitostack in cfn console, there should beUserPoolId,UserPoolAuthDomainandSNSRoleparallelcluster-ui.yaml, specify the PCluster version and fill in the External Cognito Stack Section using the output value from Step 2. Create the stack.PR Quality Checklist
react-i18nextlibrary (useTranslation hook and/or Trans component), see an example herenpm run buildbuilds without any errorIn order to increase the likelihood of your contribution being accepted, please make sure you have read both the Contributing Guidelines and the Project Guidelines
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.