[Slurm 25.11] Enable expedited requeue by default#3117
Merged
hehe7318 merged 6 commits intoaws:developfrom Mar 4, 2026
Merged
Conversation
gmarciani
reviewed
Mar 3, 2026
| # CLOUD CONFIGS OPTIONS | ||
| <% if node['cluster']['use_private_hostname'] == 'true' or node['cluster']['dns_domain'].nil? or node['cluster']['dns_domain'].empty? -%> | ||
| SlurmctldParameters=idle_on_node_suspend,power_save_min_interval=30,node_reg_mem_percent=<%= node['cluster']['slurm_node_reg_mem_percent'] %> | ||
| SlurmctldParameters=idle_on_node_suspend,power_save_min_interval=30,node_reg_mem_percent=<%= node['cluster']['slurm_node_reg_mem_percent'] %>,enable_expedited_requeue |
Contributor
There was a problem hiding this comment.
Can we cover this change with test?
Sincew we need this change asap in the build, if adding the test requires too much boilerplate/time, let;s merge this fix and work on the test in a separate PR.
gmarciani
approved these changes
Mar 4, 2026
gmarciani
reviewed
Mar 4, 2026
| @@ -26,10 +26,10 @@ LaunchParameters=enable_nss_slurm | |||
| # | |||
| # CLOUD CONFIGS OPTIONS | |||
| <% if node['cluster']['use_private_hostname'] == 'true' or node['cluster']['dns_domain'].nil? or node['cluster']['dns_domain'].empty? -%> | |||
Contributor
There was a problem hiding this comment.
[not blocking - CodeStyle,Maintenance] The if branch sets both SlurmctldParameters and TreeWidth, but we always set the same value to SlurmctldParameters. We can define SlurmctldParameters outside of the if branch.
Contributor
Author
There was a problem hiding this comment.
You are right! Fixed!
gmarciani
previously approved these changes
Mar 4, 2026
…branch SlurmctldParameters was duplicated in both if/else branches with the same value. Move it outside the conditional.
hehe7318
force-pushed
the
wip/enable-expedited-requeue
branch
from
7667b25 to
bf6ac16
Compare
gmarciani
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Tests
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.