[Update] Always restart clustermgtd on update failure#3104
Closed
gmarciani wants to merge 1 commit intoaws:developfrom
Closed
[Update] Always restart clustermgtd on update failure#3104gmarciani wants to merge 1 commit intoaws:developfrom
gmarciani wants to merge 1 commit intoaws:developfrom
Conversation
…ess the point of failure. Before this change, clustermgtd was restarted only if the update recipe failed the cluster readiness check. This change is meant to reduce the chances of having clustermgtd stopped after a failed update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Always restart clustermgtd on update failure, regardless the point of failure.
Before this change, clustermgtd was restarted only if the update recipe failed the cluster readiness check.
This change is meant to reduce the chances of having clustermgtd stopped after a failed update.
UX
clustermgtd gets restarted on update recipe failure (both update and rollback):
Tests
test_update_rollback_failureBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.