fix: exclude ASG terminating instances from cluster readiness check#3080
Open
almightychang wants to merge 1 commit intoaws:developfrom
Open
Conversation
When LoginNodes (or Compute nodes) are being deleted, instances enter ASG Terminating:Wait state but EC2 still reports them as 'running'. The readiness check was including these instances, causing failures because they have the old config version and will never update. This fix queries ASG lifecycle states and excludes instances in Terminating:Wait or Terminating:Proceed from the readiness check. Fixes aws/aws-parallelcluster#7172
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_asg_terminating_instance_ids()function to query instances in ASG terminating lifecycle statesTerminating:WaitorTerminating:Proceedfrom readiness check validationProblem
When LoginNodes are deleted (e.g., setting
Count: 0), the cluster update fails because:Terminating:Waitstaterunning(lifecycle hook hasn't completed)Solution
Query ASG lifecycle states before readiness check and exclude instances that are in:
Terminating:WaitTerminating:ProceedThese instances are being removed and should not be validated against the new config version.
Test Plan
Fixes aws/aws-parallelcluster#7172