Include Slurm resume plugin config update to support ScalingStrategy update#2983
Closed
hanwen-cluster wants to merge 1 commit intoaws:developfrom
Closed
Include Slurm resume plugin config update to support ScalingStrategy update#2983hanwen-cluster wants to merge 1 commit intoaws:developfrom
ScalingStrategy update#2983hanwen-cluster wants to merge 1 commit intoaws:developfrom
Conversation
…` update Signed-off-by: Hanwen <hanwenli@amazon.com>
gmarciani
reviewed
Jun 24, 2025
| not_if { ::File.exist?(node['cluster']['previous_cluster_config_path']) && !are_queues_updated? && !are_bulk_custom_slurm_settings_updated? } | ||
| end | ||
|
|
||
| include_recipe 'aws-parallelcluster-slurm::config_slurm_resume' |
Contributor
There was a problem hiding this comment.
Can we add a unit test verifying that the recipe is always called as part of the update?
Contributor
|
How has this change been tested? Can you please provide some information in the PR description? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Tests
References
Checklist
developadd the branch name as prefix in the PR title (e.g.[release-3.6]).Please review the guidelines for contributing and Pull Request Instructions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.