Skip to content

Avoid infinite log resending if exceptions happen during the log-sending process#219

Open
amidofu wants to merge 3 commits intoaws:devfrom
boostdraft:master
Open

Avoid infinite log resending if exceptions happen during the log-sending process#219
amidofu wants to merge 3 commits intoaws:devfrom
boostdraft:master

Conversation

@amidofu
Copy link
Copy Markdown

@amidofu amidofu commented May 12, 2023

Issue #, if available:

Description of changes:

  1. We drop the logs in the log batch if the current log batch causes exceptions in the log-sending process
  2. we set the auth region by the config region if the service url is used

For 1., we did this because we observed that our log batch causes the over 24 hours spanning problem
and since the monitor is not stopped, it just resends the log batch forever.

For 2., we did this because we got a problem with the auth region setup

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

amidofu and others added 3 commits May 10, 2023 14:26
set auth region when service url is used
* drop logs if exceptions happen

* avoid 24 hours rule

* remove test code

* combine exceptions
@ashovlin ashovlin requested review from ashovlin and removed request for ashovlin June 13, 2023 15:22
@ashovlin ashovlin self-assigned this Jun 13, 2023
@ashishdhingra ashishdhingra added feature-request A feature should be added or improved. module/logging p2 This is a standard priority issue labels Sep 1, 2023
@ashishdhingra ashishdhingra changed the title avoid infinite log resending if exceptions happen during the log-sending process Avoid infinite log resending if exceptions happen during the log-sending process Sep 1, 2023
@ashishdhingra ashishdhingra requested a review from ashovlin May 31, 2024 16:34
@ashishdhingra ashishdhingra requested review from GarrettBeatty, normj and philasmar and removed request for ashovlin February 13, 2025 17:50
@GarrettBeatty GarrettBeatty changed the base branch from main to dev August 19, 2025 01:49
@GarrettBeatty
Copy link
Copy Markdown
Collaborator

do we know if this issue is still happening in the latest version @amidofu

@peterrsongg peterrsongg added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Mar 19, 2026
@afroz429
Copy link
Copy Markdown

@amidofu are you able to confirm if this issue is still happening?

@github-actions github-actions Bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Apr 23, 2026
@amidofu
Copy link
Copy Markdown
Author

amidofu commented Apr 23, 2026

@afroz429
sorry, I can't confirm it now, I have some trouble making your latest version work in my env, I'm trying to figure out why.

I think you can test it by adding an event like

InputLogEvent tmp = new InputLogEvent
{
    Message = "test",
    Timestamp = DateTime.UtcNow.AddDays(-2);
}
_repo.AddMessage(tmp);

to here

and see if Monitor keeps sending the same log events in _repo

thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-request A feature should be added or improved. module/logging p2 This is a standard priority issue queued

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants