Skip to content

Conversation

@ashishdhingra
Copy link
Contributor

Issue #, if available: P340365477

Description of changes:
Marked ProxyRequestContext.Error property as Obsolete for APIGatewayProxyRequest.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

/// <summary>
/// Gets and sets the error.
/// </summary>
[Obsolete("This property is obsolete since it is not processed by the Velocity Template Language engine and is not available as a field to integration request.")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a non obsolete field to recommend instead and if so can you mention that

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, there is no non-obsolete field. This property should not be used at all for integration. Please refer ticket (ID in description).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect most users wouldn't know the context of "Velocity Template", I had to look it up myself. I suggest keeping the error message a bit more generic that it just isn't used by the service.

This property is obsolete since it is not used by AWS API Gateway and will never have value set by the service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants