Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #983 +/- ##
==========================================
+ Coverage 87.75% 87.78% +0.02%
==========================================
Files 72 72
Lines 10136 10148 +12
Branches 1339 1340 +1
==========================================
+ Hits 8895 8908 +13
Misses 1216 1216
+ Partials 25 24 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
34cb8f4 to
297a3f8
Compare
297a3f8 to
b110e59
Compare
|
@go-to-k one more time thank you for this PR but TryBundle is called synchronously during synthesis inside the app process, before the CLI's work graph executes. Assets built locally via ILocalBundling are already resolved by the time --asset-build-concurrency takes effect. This means the flag only helps Docker-based bundling. Go/Rust CDK apps that use ILocalBundling (the recommended approach to avoid Docker overhead) cannot benefit from parallel asset builds. Could the framework defer local bundling to the work graph as well? |
|
@xrn Deferring local bundling to the work graph is a very appealing idea. However, ILocalBundling.tryBundle() is called synchronously during synthesis inside the CDK app process, which is a completely separate phase from the CLI's work graph execution. This would require changes on both the framework side (aws-cdk-lib) and the CLI side, which is a significant architectural change beyond the scope of this PR. It might be worth opening a separate feature request issue for that so the maintainers can weigh in on the approach. In the meantime, a note in the documentation clarifying that this flag applies to Docker-based builds only could also help avoid confusion. |
Fixes #226
This PR adds the
--asset-build-concurrencyoption tocdk deployto parallelize asset build.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license