Simplify code using try with resources for the Reentrant lock #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiyvamz
reviewed
Nov 8, 2022
|
|
||
| public void lock() { | ||
| lock.lock(); | ||
| public ResourceLock obtain() { |
Contributor
There was a problem hiding this comment.
I'd suggest to reconsider a method name. It's not clear what "obtain" on plugin manager object does. Does it obtain a plugin manager?
sergiyvamz
reviewed
Nov 8, 2022
| /* | ||
| For testing only | ||
| */ | ||
| public void closeResourceLock() { |
Contributor
Author
There was a problem hiding this comment.
I'm not married to any name. releaseLock is fine, and then we can use acquireLock instead of obtain.
… This is probably too specific
karenc-bq
reviewed
Nov 16, 2022
| public void close() { | ||
| this.unlock(); | ||
| } | ||
| } No newline at end of file |
karenc-bq
reviewed
Nov 16, 2022
| } | ||
| } | ||
|
|
||
| } No newline at end of file |
Contributor
Author
|
close in favour of #265 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimization to make the code simpler