fix: set instruction file content length #496
Closed
+78
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The instruction files content length must be set correctly in the PutObjectRequest. This overwrites any previously set values and always uses the correct byte length for the content of the instruction file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instruction files content length must be set correctly in the PutObjectRequest. This overwrites any previously set values and always uses the correct byte length for the content of the instruction file.
Issue #, if available:
Description of changes:
Resubmitted copy of #495 as CI can run
The issue was in
InstructionFileConfig.java, when creating the instruction file'sPutObjectRequest, the code copies all fields from the original request usingtoBuilder(), including thecontentLength. This causes the instruction file to be uploaded with the wrong content length, leading to checksum validation failures.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: