Adding unit tests for fault request ordering#4409
Closed
Conversation
mye956
force-pushed
the
fault-unit-test
branch
from
260d86e to
b81eb0c
Compare
mye956
changed the title
amogh09
reviewed
Oct 23, 2024
mye956
force-pushed
the
fault-unit-test
branch
3 times, most recently
from
7e711d0 to
65171bf
Compare
amogh09
approved these changes
Oct 23, 2024
mye956
force-pushed
the
fault-unit-test
branch
from
65171bf to
01dea21
Compare
danehlim
reviewed
Nov 13, 2024
| testNetworkFaultInjectionCommon(t, tcs, NetworkFaultPath(types.PacketLossFaultType, types.CheckNetworkFaultPostfix)) | ||
| } | ||
|
|
||
| func TestNetworkFaultRequestOrdering(t *testing.T) { |
Contributor
There was a problem hiding this comment.
nit (non-blocking): There seems to be a lot of repeated code across test cases, especially between L2242-2288 and L2289-L2335. This is not a strict blocker for me but I would prefer if we could look to minimize the amount of repeated code across test cases (for code maintainability purposes, particularly if we expect to add any new fault types in the future) and factor those out into for loop.
danehlim
approved these changes
Nov 13, 2024
mye956
force-pushed
the
fault-unit-test
branch
from
01dea21 to
0cb9d05
Compare
Contributor
|
Closing PR due to inactivity |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR will add additional unit testing for the network fault injection handlers, specifically the ordering of when each request finishes if they're modifying the same resource (e.g. the same network namespace/network interface).
The ordering/workflow is the following:
Implementation details
makeAsyncRequest(): Helper function that is called upon in a goroutine to make mock HTTP requestsTestNetworkFaultRequestOrdering(): The test cases will make two sequential asynchronous HTTP request (1 start and then 1 stop fault request). We will be mocking the first request (start fault) to be taking some time to finish while the second request (stop fault) should wait until the first request finishes before it gets executed.Testing
New test cases that were introduced:
New tests cover the changes: yes
Description for the changelog
Feature: Adding network fault request ordering unit test cases
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
Does this PR include the addition of new environment variables in the README?
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.