Implement halt on target logic #1975
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Implements halt on a target when Sender calls fail() and resumes reading from target when Sender calls done()
Description of changes
Workflow:
When Sender detects request failure, the batch.fail() is invoked, which in turn invokes the fail callback to set
bool haltedto true.When
bool haltedis true, the queue waits forhaltedto become false before sending the next batch to the SenderPool tasks queue.When Sender detects request success, the batch.done() is invoked, which in turn invokes the done callaback setting
bool haltedto false.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
All unit tests passing
Requirements
Before commiting your code, please do the following steps.
make fmtandmake fmt-shmake lintIntegration Tests
To run integration tests against this PR, add the
ready for testinglabel.