Instantiate RetryHeap and RetryHeapProcessor if concurrency enabled #1974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sky333999
previously approved these changes
Dec 31, 2025
sky333999
reviewed
Dec 31, 2025
| // Create processor's own sender and senderPool | ||
| // Note: Pass nil for retryHeap to prevent infinite retry loops - | ||
| // batches from RetryHeap that fail again use synchronous retry behavior | ||
| sender := newSender(logger, service, targetManager, maxRetryDuration, true, nil) |
Contributor
There was a problem hiding this comment.
If the last arg here i.e. the retryHeap is set to nil, doesnt that defeat the entire purpose? Since this sender that is for the retry batches will now follow the old sync flow and block thus eventually causing all workers to block?
I was expecting the batches pop'ed from the retryHeap to also go back again onto the retryHeap.
Contributor
Author
There was a problem hiding this comment.
Discussed this separately, we will need to define the sender to invoke sender.send().
sky333999
dismissed
their stale review
Pending clarification on sender used in RetryHeapProcessor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Instantiate RetryHeap and RetryHeapProcessor if concurrency enabled, and push retryable batches to RetryHeap from Sender
Description of changes
Instantiates RetryHeap and RetryHeapProcessor at plugin level if concurrency is enabled
This will ensure a single RetryHeap and Processor across all Targets.
The RetryHeapProcessor should not take reference to a SenderPool dedicated to a given pusher, so it instead creates its own instance in order to push ready batches to the SenderQueue (tasks() channel)
Sender will push batch to retryheap on failure after recalculating retry metadata.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
All tests are passing
Requirements
Before commiting your code, please do the following steps.
make fmtandmake fmt-shmake lintIntegration Tests
To run integration tests against this PR, add the
ready for testinglabel.