Fix GPU Integ Tests and add PV, PVC Integ Tests#637
Merged
Conversation
ad2fe49 to
2f69d83
Compare
sky333999
commented
Dec 16, 2025
2f69d83 to
4efe31c
Compare
movence
previously approved these changes
Dec 17, 2025
the-mann
previously approved these changes
Dec 17, 2025
Contributor
the-mann
left a comment
There was a problem hiding this comment.
overall really good change, thanks for getting this done. I have a couple suggestions on how we can improve the debugging experience if the test fails again
|
|
||
| provisioner "local-exec" { | ||
| command = <<-EOT | ||
| cd ../../../.. |
Contributor
There was a problem hiding this comment.
a bit nitpicky, but can we use something like
cd "$(git rev-parse --show-toplevel)"
instead?
Contributor
Author
There was a problem hiding this comment.
Thinking if we should avoid adding a dependency on git for this..
For our GH runners specifically, it should work - but assuming someone has this code available somehow without git, may end up causing some pain.
Contributor
There was a problem hiding this comment.
i think that's a pretty extreme edge case, no?
4efe31c to
3a5c5b1
Compare
the-mann
approved these changes
Jan 8, 2026
movence
approved these changes
Jan 8, 2026
JayPolanco
pushed a commit
that referenced
this pull request
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
1) Make GPU addon test consistent with GPU daemon test
2) Use actual GPU nodes for GPU daemon test and spin up real
gpu-burn3) Update PV & PVC tests
4) Remove unnecessary
UseE2EMetricsflag and clean up related codeLicense
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
https://github.com/aws/amazon-cloudwatch-agent/actions/runs/20257453246 shows passing integ tests for GPU/Daemon and GPU/Addon.