Skip to content

fix: auto-trigger ingestion on connector config file content changes#1732

Merged
jariy17 merged 1 commit into
mainfrom
kb-ingestion-update
Jul 10, 2026
Merged

fix: auto-trigger ingestion on connector config file content changes#1732
jariy17 merged 1 commit into
mainfrom
kb-ingestion-update

Conversation

@nborges-aws

Copy link
Copy Markdown
Contributor

Description

Previously, auto-ingestion only triggered when a data source was added/removed or its file path changed. If a user edited their app/<kbName>/confluence.json to change the Confluence space, filters, or host URL, the hash was unchanged (same path) and ingestion was skipped — leaving the KB serving stale content from the old configuration.

computeSourcesHash now hashes the content of connector config files instead of just the file path. This guarantees edits to filters, host URLs, credentials, or any other connector configuration will trigger re-ingestion on the next deploy even when the filename is unchanged.

  • falls back to path-based hashing if the file cannot be read, so deploy is never blocked.
  • Passes projectRoot through from both the CLI and TUI deploy flows.

Related Issue

Closes #

Documentation PR

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@nborges-aws nborges-aws requested a review from a team July 10, 2026 16:20
@github-actions github-actions Bot added the size/m PR size: M label Jul 10, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added the claude-security-reviewing Claude Code /security-review in progress label Jul 10, 2026
@github-actions github-actions Bot added agentcore-harness-reviewing AgentCore Harness review in progress and removed agentcore-harness-reviewing AgentCore Harness review in progress labels Jul 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Package Tarball

aws-agentcore-0.23.0.tgz

How to install

gh release download pr-1732-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.23.0.tgz

@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Jul 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 39.71% 14735 / 37102
🔵 Statements 38.98% 15707 / 40287
🔵 Functions 33.82% 2511 / 7423
🔵 Branches 33.33% 9839 / 29513
Generated in workflow #4073 for commit 77f4a40 by the Vitest Coverage Report Action

@jariy17 jariy17 merged commit a93302b into main Jul 10, 2026
34 of 35 checks passed
@jariy17 jariy17 deleted the kb-ingestion-update branch July 10, 2026 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/m PR size: M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants