Revert "feat(run): add --kms-key flag to run insights for KMS parity (#1688)"#1723
Merged
Conversation
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
github-actions
Bot
added
the
agentcore-harness-reviewing
Contributor
Package TarballHow to installgh release download pr-1723-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.23.0.tgz |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
agentcore-cli-automation
approved these changes
Jul 9, 2026
agentcore-cli-automation
left a comment
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
Clean, complete revert of #1688. Diff exactly mirrors the original commit (same 3 files, same 6 lines removed). No tests were added in #1688, so nothing test-related needs reverting either.
Verified no lingering references to kmsKeyArn remain in the insights code path (src/cli/commands/run/, src/cli/operations/jobs/insights/, or in StartInsightsJobOptions), so this compiles cleanly. Sibling commands (run batch-evaluation, run recommendation) retain their --kms-key support, as expected.
LGTM — safe to merge.
github-actions
Bot
removed
the
agentcore-harness-reviewing
Contributor
Coverage Report
|
tejaskash
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #1688, which added a
--kms-keyflag torun insightsfor KMS parity withrun batch-evaluationandrun recommendation.This reverts merge commit e61338c.
Reverted changes
src/cli/commands/run/command.tsx— removes--kms-key <arn>fromrun insights.src/cli/operations/jobs/shared/types.ts— removeskmsKeyArn?fromStartInsightsJobOptions.src/cli/operations/jobs/insights/handler.ts— stops threadingkmsKeyArnthrough tostartBatchEvaluation.Re-opens #1655.