ci(e2e): skip E2E tests on docs-only PRs#1705
Merged
Merged
Conversation
Adds a paths filter to the pull_request_target trigger so E2E tests only run when a change can actually affect agent behavior: CLI source, e2e or browser tests, packaging manifests, the vitest config, or the e2e workflow files. Docs-only PRs (and other non-code changes) no longer consume a shared CI AWS account slot or ~30 min of runtime. Includes package-lock.json / npm-shrinkwrap.json alongside package.json so dependency-only changes still trigger the suite.
github-actions
Bot
added
the
agentcore-harness-reviewing
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
Package TarballHow to installgh release download pr-1705-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.22.0.tgz |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
agentcore-cli-automation
suggested changes
Jul 8, 2026
agentcore-cli-automation
left a comment
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
Sensible change overall — the paths filter cleanly excludes docs-only PRs. One gap worth addressing before merging: several files that affect what E2E actually tests aren't in the filter, so changes to them would silently skip E2E. Left an inline comment with specifics.
github-actions
Bot
removed
the
agentcore-harness-reviewing
aidandaly24
previously approved these changes
Jul 8, 2026
Address review: the paths filter omitted files that produce the agentcore binary E2E installs. Add tsconfig*.json (build:lib), esbuild.config.* (build:cli), and scripts/** (bundle/copy-assets/generate-schema plus the check-old-cli.mjs postinstall hook). A change to any of these in isolation would otherwise silently skip E2E.
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
aidandaly24
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a paths filter to pull_request_target so E2E only runs when CLI source, e2e/browser tests, packaging manifests, vitest config, or the e2e workflows change. Docs-only PRs no longer consume a CI AWS account slot
or ~30 min runtime.