Skip to content

fix(tui): use "No memory" instead of "Disabled" in harness memory picker #1635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aidandaly24 merged 1 commit into from
Jun 24, 2026
Merged

fix(tui): use "No memory" instead of "Disabled" in harness memory picker #1635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cli/tui/screens/harness/AddHarnessScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ export function AddHarnessScreen({
fields.push({ label: 'Memory Relevance Score', value: String(mem.relevanceScore) });
}
} else {
fields.push({ label: 'Memory', value: 'Disabled' });
fields.push({ label: 'Memory', value: 'No memory' });
}
}

Expand Down
7 changes: 4 additions & 3 deletions src/cli/tui/screens/harness/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,10 @@ export type AdvancedSetting = (typeof ADVANCED_SETTING_OPTIONS)[number]['id'];

/** Mode-first memory options. Mirrors the schema's 3-mode union. */
export const MEMORY_MODE_OPTIONS = [
// Disabled is first so it is the highlighted default (the picker selects index 0). Memory is
// opt-in: a harness has no memory unless the user picks Managed or Existing here.
{ id: 'disabled' as const, title: 'Disabled', description: 'No memory (default)' },
// "No memory" is first so it is the highlighted default (the picker selects index 0). Memory is
// opt-in: a harness has no memory unless the user picks Managed or Existing here. The id stays
// 'disabled' — it is the schema/CFN contract token; only the displayed title is reworded.
{ id: 'disabled' as const, title: 'No memory', description: 'Default' },
{
id: 'managed' as const,
title: 'Managed',
Expand Down
Loading