Skip to content

fix(run-insights): reject empty --name "" instead of auto-generating #1600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jariy17 merged 2 commits into from
Jun 29, 2026
Merged

fix(run-insights): reject empty --name "" instead of auto-generating #1600

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c309a77
fix(run-insights): reject empty --name "" instead of auto-generating
notgitika Jun 22, 2026
c0570d7
fix: move --name validation inside runCliCommand callback
notgitika Jun 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/cli/commands/run/command.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,12 +399,16 @@ export const registerRun = (program: Command) => {
};

await runCliCommand('run.job', !!cliOptions.json, async () => {
if (cliOptions.name?.trim() === '') {
throw new ValidationError('--name must not be empty. Omit the flag to auto-generate a name.');
}

const engine = createJobEngine(new ConfigIO());

const insightIds = cliOptions.insights ?? ['Builtin.Insight.FailureAnalysis'];
const lookbackDays = cliOptions.lookbackDays ? parseInt(cliOptions.lookbackDays, 10) : undefined;
if (lookbackDays !== undefined && (isNaN(lookbackDays) || lookbackDays < 1 || lookbackDays > 90)) {
throw new Error('--lookback-days must be between 1 and 90');
throw new ValidationError('--lookback-days must be a positive integer between 1 and 90.');
}

const startResult = await engine.start('insights', {
Expand Down
Loading