sync-preview: merge main into preview (conflicts)#1242
Merged
Conversation
* feat: instrument telemetry for dev command
Add telemetry recording to the dev command across all execution paths:
- Invoke: wrapped with withCommandRunTelemetry, emits on success/failure
- Exec: wrapped with withCommandRunTelemetry for container exec
- Server modes (--logs, --no-browser, browser): emit on SIGINT/exit
Schema changes:
- Expand Action enum to include 'exec'
- Add UiMode enum ('browser' | 'terminal')
- Add 'agui' to Protocol enum
- Add ui_mode field to DevAttrs
Refactored invoke helpers to throw instead of process.exit(1) so
telemetry wrapper can record failures before exit.
Attributes emitted: action, ui_mode, has_stream, protocol, invoke_count
* refactor: use typed errors in dev command helpers + emit browser telemetry eagerly
Error classification:
- ConnectionError for connection-refused (new class in lib/errors/types.ts)
- ValidationError for invalid user input (missing --tool, bad JSON, unknown command)
- ResourceNotFoundError for missing container runtime
Browser mode telemetry:
- Emit telemetry eagerly via TelemetryClientAccessor before the blocking
runBrowserMode call (which never returns). Do not copy this pattern —
prefer withCommandRunTelemetry for commands that return.
Hweinstock
force-pushed
the
sync-preview/merge-main-20260513-230210
branch
from
2ead886 to
d43ea9c
Compare
Hweinstock
force-pushed
the
sync-preview/merge-main-20260513-230210
branch
from
044f5b3 to
3a4b747
Compare
Contributor
Coverage Report
|
Hweinstock
force-pushed
the
sync-preview/merge-main-20260513-230210
branch
from
056afb9 to
fbb4b5b
Compare
Hweinstock
reviewed
May 14, 2026
Hweinstock
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The automated sync could not cleanly merge
mainintopreview.This PR contains conflict markers. To resolve:
cc @Hweinstock
Opened automatically by the sync-preview workflow.