feat: add Anthropic best practice checks (STR-018, STR-019, STR-020)#1
Merged
melanie531 merged 1 commit intomainfrom Mar 17, 2026
Merged
feat: add Anthropic best practice checks (STR-018, STR-019, STR-020)#1melanie531 merged 1 commit intomainfrom
melanie531 merged 1 commit intomainfrom
Conversation
Add three new structure checks based on agentskills.io spec and
Anthropic skill authoring best practices:
- STR-018 (WARNING): Name contains reserved words ('anthropic', 'claude')
Per agentskills.io spec, names must not contain these reserved words.
- STR-019 (WARNING): Description contains XML tags
Per agentskills.io spec, description must not contain XML/HTML tags
as they can interfere with system prompt injection.
- STR-020 (INFO): Description should use third person
Per Anthropic best practices, descriptions should use third person
('Processes files') instead of first person ('I can help') or
second person ('You can use'). Inconsistent point-of-view causes
discovery problems.
All three are pure static checks (no LLM needed).
Includes 10 new test cases covering positive and negative scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add three new structure checks based on agentskills.io spec and Anthropic skill authoring best practices:
STR-018 (WARNING): Name contains reserved words ('anthropic', 'claude') Per agentskills.io spec, names must not contain these reserved words.
STR-019 (WARNING): Description contains XML tags Per agentskills.io spec, description must not contain XML/HTML tags as they can interfere with system prompt injection.
STR-020 (INFO): Description should use third person Per Anthropic best practices, descriptions should use third person ('Processes files') instead of first person ('I can help') or second person ('You can use'). Inconsistent point-of-view causes discovery problems.
All three are pure static checks (no LLM needed).
Includes 10 new test cases covering positive and negative scenarios.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.