test(gui): update login flow test suite to use newer auth widget#988
Merged
epmog merged 1 commit intoaws-deadline:mainlinefrom Feb 10, 2026
Merged
Conversation
larrygao001
reviewed
Feb 3, 2026
Comment on lines
+73
to
78
| authentication_profile_button = { | ||
| "container": authentication_status_widget, | ||
| "type": "QPushButton", | ||
| "unnamed": 1, | ||
| "visible": 1, | ||
| } |
Contributor
There was a problem hiding this comment.
Aren't there multiple buttons such as login, switch profile, and more info?
Contributor
Author
There was a problem hiding this comment.
I only see "Log in" as an button within that widget. Do you see other buttons?
Contributor
There was a problem hiding this comment.
You're right, I was confused by line 10.
andychoquette
force-pushed
the
chore/fix-squish-tests
branch
4 times, most recently
from
ca165fa to
f5c5770
Compare
larrygao001
approved these changes
Feb 7, 2026
Comment on lines
+73
to
78
| authentication_profile_button = { | ||
| "container": authentication_status_widget, | ||
| "type": "QPushButton", | ||
| "unnamed": 1, | ||
| "visible": 1, | ||
| } |
Contributor
There was a problem hiding this comment.
You're right, I was confused by line 10.
crowecawcaw
approved these changes
Feb 7, 2026
epmog
approved these changes
Feb 9, 2026
epmog
force-pushed
the
chore/fix-squish-tests
branch
from
f5c5770 to
3076a06
Compare
epmog
changed the title
|
andychoquette
force-pushed
the
chore/fix-squish-tests
branch
from
3076a06 to
50d97e1
Compare
Signed-off-by: apcho <apcho@amazon.com>
andychoquette
force-pushed
the
chore/fix-squish-tests
branch
from
50d97e1 to
a0f2e3f
Compare
|
This was referenced Feb 24, 2026
Closed
Merged
crowecawcaw
added a commit
to crowecawcaw/deadline-cloud
that referenced
this pull request
Feb 26, 2026
…ine GUI (aws-deadline#988) Signed-off-by: apcho <apcho@amazon.com> Co-authored-by: apcho <apcho@amazon.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
What was the problem/requirement? (What/Why)
The existing squish UI tests were checking for the presence of UI elements that no longer exist, specifically the AUTHENTICATED and AUTHORIZED components, and the "OK" button, which is now "Ok".
What was the solution? (How)
Update the selectors to target existing elements
What is the impact of this change?
Squish test suite will pass.
How was this change tested?
I ran the Squish tests locally.
Was this change documented?
No changes to documentation, but docstrings were added to clarify the functionality of the selectors
Does this PR introduce new dependencies?
This library is designed to be integrated into third-party applications that have bespoke and customized deployment environments. Adding dependencies will increase the chance of library version conflicts and incompatabilities. Please evaluate the addition of new dependencies. See the Dependencies section of DEVELOPMENT.md for more details.
Is this a breaking change?
No
Does this change impact security?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.