Use delta rather than markers in gridpoints_in_polygon#165
Open
Use delta rather than markers in gridpoints_in_polygon#165
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gridpoints_in_polygonlooks at one row of a grid at a time. For every polygon edge intersecting that row, it marks every grid point to the left of that edge, adding or subtracting 1 depending on the edge direction.This just adds a delta at the first element and at the new edge, then does a prefix sum at the end. We also now avoid some other unnecessary allocations. The results are the same, verified against full designs, but we get ~3x improvement in benchmark times and huge improvement in allocations for large grids. Integration benchmarks ("coarse and fine") don't see the full speedup because they spend time on geometry construction.
Old:
["autofill", "coarse_and_fine"]["autofill", "gridpoints_in_polygon", "3201x2401"]["autofill", "gridpoints_in_polygon", "321x241"]["autofill", "gridpoints_in_polygon", "33x25"]New:
["autofill", "coarse_and_fine"]["autofill", "gridpoints_in_polygon", "3201x2401"]["autofill", "gridpoints_in_polygon", "321x241"]["autofill", "gridpoints_in_polygon", "33x25"]