Skip to content

fix: enable tag support for EventSourceMapping and CodeSigningConfig #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
michaelhtm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: enable tag support for EventSourceMapping and CodeSigningConfig #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ack_generate_info:
build_date: "2026-05-19T18:45:56Z"
build_hash: e581e886276bd781409a3fb11fa665ea31de17d4
go_version: go1.26.3
version: v0.59.1
api_directory_checksum: ad8a2035e4a8544f07f3e4abca4230d8f263825f
build_date: "2026-05-28T17:24:10Z"
build_hash: a307e8ebd9503616baf5915c744a30dc3aa227c5
go_version: go1.26.0
version: v0.59.1-4-ga307e8e
api_directory_checksum: 724abf607fd4087003c76eb067be19183335b0b3
api_version: v1alpha1
aws_sdk_go_version: v1.41.0
generator_config_info:
file_checksum: 828bfa9ac502243758276efadc8d2d4c22a96c3b
file_checksum: 3b86776dae0de6feef92d5a7d0ea25085f0800eb
original_file_name: generator.yaml
last_modification:
reason: API generation
2 changes: 2 additions & 0 deletions apis/v1alpha1/code_signing_config.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions apis/v1alpha1/event_source_mapping.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 9 additions & 6 deletions apis/v1alpha1/generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,10 @@ ignore:
# FunctionUrlConfig
# LayerVersion
field_paths:
- CreateCodeSigningConfigInput.Tags
- CreateEventSourceMappingInput.DocumentDBEventSourceConfig
- CreateEventSourceMappingInput.KMSKeyArn
- CreateEventSourceMappingInput.MetricsConfig
- CreateEventSourceMappingInput.ProvisionedPollerConfig
- CreateEventSourceMappingInput.Tags
- CreateEventSourceMappingOutput.FilterCriteriaError
- CreateEventSourceMappingOutput.DocumentDBEventSourceConfig
- CreateEventSourceMappingOutput.KMSKeyArn
Expand Down Expand Up @@ -204,8 +202,11 @@ resources:
fields:
AllowedPublishers:
is_required: true
tags:
ignore: true
hooks:
sdk_read_one_post_set_output:
template_path: hooks/codesigningconfig/sdk_read_one_post_set_output.go.tpl
sdk_update_pre_build_request:
template_path: hooks/codesigningconfig/sdk_update_pre_build_request.go.tpl
EventSourceMapping:
fields:
Queues:
Expand Down Expand Up @@ -245,10 +246,12 @@ resources:
hooks:
delta_pre_compare:
code: customPreCompare(delta, a, b)
sdk_read_one_post_set_output:
template_path: hooks/eventsourcemapping/sdk_read_one_post_set_output.go.tpl
sdk_update_pre_build_request:
template_path: hooks/eventsourcemapping/sdk_update_pre_build_request.go.tpl
sdk_update_post_build_request:
template_path: hooks/eventsourcemapping/sdk_update_post_build_request.go.tpl
tags:
ignore: true
FunctionUrlConfig:
tags:
ignore: true
Expand Down
32 changes: 32 additions & 0 deletions apis/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions config/crd/bases/lambda.services.k8s.aws_codesigningconfigs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@ spec:
description:
description: Descriptive name for this code signing configuration.
type: string
tags:
additionalProperties:
type: string
description: A list of tags to add to the code signing configuration.
type: object
required:
- allowedPublishers
type: object
Expand Down
5 changes: 5 additions & 0 deletions config/crd/bases/lambda.services.k8s.aws_eventsourcemappings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,11 @@ spec:
StartingPositionTimestamp cannot be in the future.
format: date-time
type: string
tags:
additionalProperties:
type: string
description: A list of tags to apply to the event source mapping.
type: object
topics:
description: The name of the Kafka topic.
items:
Expand Down
15 changes: 9 additions & 6 deletions generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,10 @@ ignore:
# FunctionUrlConfig
# LayerVersion
field_paths:
- CreateCodeSigningConfigInput.Tags
- CreateEventSourceMappingInput.DocumentDBEventSourceConfig
- CreateEventSourceMappingInput.KMSKeyArn
- CreateEventSourceMappingInput.MetricsConfig
- CreateEventSourceMappingInput.ProvisionedPollerConfig
- CreateEventSourceMappingInput.Tags
- CreateEventSourceMappingOutput.FilterCriteriaError
- CreateEventSourceMappingOutput.DocumentDBEventSourceConfig
- CreateEventSourceMappingOutput.KMSKeyArn
Expand Down Expand Up @@ -204,8 +202,11 @@ resources:
fields:
AllowedPublishers:
is_required: true
tags:
ignore: true
hooks:
sdk_read_one_post_set_output:
template_path: hooks/codesigningconfig/sdk_read_one_post_set_output.go.tpl
sdk_update_pre_build_request:
template_path: hooks/codesigningconfig/sdk_update_pre_build_request.go.tpl
EventSourceMapping:
fields:
Queues:
Expand Down Expand Up @@ -245,10 +246,12 @@ resources:
hooks:
delta_pre_compare:
code: customPreCompare(delta, a, b)
sdk_read_one_post_set_output:
template_path: hooks/eventsourcemapping/sdk_read_one_post_set_output.go.tpl
sdk_update_pre_build_request:
template_path: hooks/eventsourcemapping/sdk_update_pre_build_request.go.tpl
sdk_update_post_build_request:
template_path: hooks/eventsourcemapping/sdk_update_post_build_request.go.tpl
tags:
ignore: true
FunctionUrlConfig:
tags:
ignore: true
Expand Down
5 changes: 5 additions & 0 deletions helm/crds/lambda.services.k8s.aws_codesigningconfigs.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@ spec:
description:
description: Descriptive name for this code signing configuration.
type: string
tags:
additionalProperties:
type: string
description: A list of tags to add to the code signing configuration.
type: object
required:
- allowedPublishers
type: object
Expand Down
5 changes: 5 additions & 0 deletions helm/crds/lambda.services.k8s.aws_eventsourcemappings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,11 @@ spec:
StartingPositionTimestamp cannot be in the future.
format: date-time
type: string
tags:
additionalProperties:
type: string
description: A list of tags to apply to the event source mapping.
type: object
topics:
description: The name of the Kafka topic.
items:
Expand Down
5 changes: 5 additions & 0 deletions pkg/resource/code_signing_config/delta.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

26 changes: 26 additions & 0 deletions pkg/resource/code_signing_config/hooks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package code_signing_config

import (
"context"

acktags "github.com/aws-controllers-k8s/lambda-controller/pkg/resource/tags"
)

func (rm *resourceManager) getTags(
ctx context.Context,
resourceARN string,
) (map[string]*string, error) {
return acktags.GetTags(ctx, rm.sdkapi, rm.metrics, resourceARN)
}

func (rm *resourceManager) syncTags(
ctx context.Context,
desired *resource,
latest *resource,
) error {
return acktags.SyncTags(
ctx, rm.sdkapi, rm.metrics,
string(*latest.ko.Status.ACKResourceMetadata.ARN),
desired.ko.Spec.Tags, latest.ko.Spec.Tags,
)
}
34 changes: 31 additions & 3 deletions pkg/resource/code_signing_config/manager.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 18 additions & 0 deletions pkg/resource/code_signing_config/sdk.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading