feat(gen2-migration): integrate gen1 test scripts and add npm configure#14699
Merged
iankhou merged 1 commit intogen2-migrationfrom Mar 30, 2026
Merged
feat(gen2-migration): integrate gen1 test scripts and add npm configure#14699iankhou merged 1 commit intogen2-migrationfrom
iankhou merged 1 commit intogen2-migrationfrom
Conversation
iankhou
requested changes
Mar 24, 2026
Contributor
iankhou
left a comment
There was a problem hiding this comment.
Looks good, added suggestions to remove steps in comments like we talked about during standup. Also, please remove the duplicate logging logic. You can use a conditional to log what's necessary to each logging level. Your test script should also differentiate between more than INFO and DEBUG. What about WARNING and ERROR?
0eabfcb to
2a1ecba
Compare
Base automatically changed from
iankhou-gen2-migration-e2e-categories
to
gen2-migration
March 27, 2026 19:47
…tion and workflow enhancements Add runGen1TestScript function that copies _test-common, installs deps, and runs gen1-test-script.ts at three stages: post-push, post-refactor, and post-redeployment. Partitions stdout into DEBUG (non-summary) and INFO (test results) to avoid duplicate log lines with --verbose. Also adds configure.sh support, post-refactor commit step, and uses getCLIPath for amplify push. --- Prompt: rebase on gen2-migration with squashed cli.ts changes including test script integration, partitioned logging fix, configure.sh support, and workflow step additions.
50813e2 to
5a53743
Compare
iankhou
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to automate running of the gen1 test script at three main points:
There is also a functionality added to run
configure.shif it exists in the app directory.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.