Skip to content

feat(gen2-migration): integrate gen1 test scripts and add npm configure#14699

Merged
iankhou merged 1 commit intogen2-migrationfrom
sanjrkmr/include-test-script-v2
Mar 30, 2026
Merged

feat(gen2-migration): integrate gen1 test scripts and add npm configure#14699
iankhou merged 1 commit intogen2-migrationfrom
sanjrkmr/include-test-script-v2

Conversation

@sanjanaravikumar-az
Copy link
Copy Markdown
Contributor

This PR is meant to automate running of the gen1 test script at three main points:

  • post push of the gen1 app
  • post refactor
  • post redeployment after refactor

There is also a functionality added to run configure.sh if it exists in the app directory.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sanjanaravikumar-az sanjanaravikumar-az requested a review from a team as a code owner March 24, 2026 14:43
@sanjanaravikumar-az sanjanaravikumar-az changed the title feat: integrate gen1 test scripts and add npm configure feat(gen2-migration): integrate gen1 test scripts and add npm configure Mar 24, 2026
Copy link
Copy Markdown
Contributor

@iankhou iankhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added suggestions to remove steps in comments like we talked about during standup. Also, please remove the duplicate logging logic. You can use a conditional to log what's necessary to each logging level. Your test script should also differentiate between more than INFO and DEBUG. What about WARNING and ERROR?

@iankhou iankhou force-pushed the iankhou-gen2-migration-e2e-categories branch from 0eabfcb to 2a1ecba Compare March 27, 2026 15:07
Base automatically changed from iankhou-gen2-migration-e2e-categories to gen2-migration March 27, 2026 19:47
…tion and workflow enhancements

Add runGen1TestScript function that copies _test-common, installs
deps, and runs gen1-test-script.ts at three stages: post-push,
post-refactor, and post-redeployment. Partitions stdout into
DEBUG (non-summary) and INFO (test results) to avoid duplicate
log lines with --verbose. Also adds configure.sh support,
post-refactor commit step, and uses getCLIPath for amplify push.
---
Prompt: rebase on gen2-migration with squashed cli.ts changes
including test script integration, partitioned logging fix,
configure.sh support, and workflow step additions.
@sanjanaravikumar-az sanjanaravikumar-az force-pushed the sanjrkmr/include-test-script-v2 branch from 50813e2 to 5a53743 Compare March 30, 2026 18:46
@iankhou iankhou merged commit 38bca59 into gen2-migration Mar 30, 2026
4 checks passed
@iankhou iankhou deleted the sanjrkmr/include-test-script-v2 branch March 30, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants