feat: update feature coverage of GEN2_MIGRATION_GUIDE.md#14686
feat: update feature coverage of GEN2_MIGRATION_GUIDE.md#14686dgandhi62 wants to merge 2 commits intogen2-migrationfrom
Conversation
This pr adds untested details on the type of frontend deployment
… in the right format
|
|
||
| ### `amplify add hosting` 🔴 | ||
|
|
||
| - ➤ **Select the plugin module to execute** |
There was a problem hiding this comment.
What are we trying to convey with this messaging? I'm concerned this communicates that there are hosting equivalents for each of these selections in Gen2 - when in fact Gen2 doesn't offer anything except full CI/CD deployments...
I think this needs some more thought. Lets discuss offline.
There was a problem hiding this comment.
I don't see the user being confused here since amplify add hosting is a command exclusive to Gen1, as are the prompts mentioned after it. By saying it is untested, or unsupported, or supported, the claim is not that Gen2 supports this. The claim is about our handling of it.
Example in point - dynamodb. By claiming we are supporting dynamodb does not claim that Gen2 supports it.
I am open to editing the feature coverage preface by making this explicit that the following section highlights what we handle during migration and does not make any claims regarding Gen2 native support. Just that this applies to every command and option mentioned in this section.
There was a problem hiding this comment.
Example in point - dynamodb. By claiming we are supporting dynamodb does not claim that Gen2 supports it.
But it does support, via CDK. Thats kind of the point - marking it as "supported" means that we provide a way for you to get the same functionality in Gen2. With hosting its not like that.
I am open to editing the feature coverage preface by making this explicit.
What did you have in mind?
2 participants
This pr updates the feature coverage section to match the latest updates by the engineering team.
Source of truth - https://docs.amplify.aws/gen1/javascript/tools/cli/hosting/