Document and automate workload identity permissions for deployment#5
Open
awood-ops wants to merge 1 commit into
Open
Document and automate workload identity permissions for deployment#5awood-ops wants to merge 1 commit into
awood-ops wants to merge 1 commit into
Conversation
Callout: the deploy identity behind Azure-Service-Connection (and the separate e2e GitHub OIDC app) needs Contributor at resource-group scope, one-time subscription-scope rights to register Microsoft.DevCenter and Microsoft.DevOpsInfrastructure, and Azure DevOps org-level membership of "DevOps Infrastructure Pool Administrators" -- Azure RBAC alone isn't enough since ADO permissions are a separate system. Adds scripts/Grant-WorkloadIdentityAccess.ps1 to automate granting all of the above (idempotent, -WhatIf supported), and documents the permissions table plus recommends workload identity federation over the classic secret-based service connection in docs/Getting-Started.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contributorat resource-group scope, one-time subscription-scope rights to registerMicrosoft.DevCenter/Microsoft.DevOpsInfrastructure, and Azure DevOps org-level membership ofDevOps Infrastructure Pool Administrators(a separate permission system from Azure RBAC).scripts/Grant-WorkloadIdentityAccess.ps1to automate granting all of the above — idempotent,-WhatIfsupported, with separate flags for the production deploy identity vs. the e2e test identity (-IncludeSubscriptionScope -SkipAdoGroupMembership).docs/Getting-Started.md.Test plan
Get-Help ./scripts/Grant-WorkloadIdentityAccess.ps1 -Fullrenders correctly-WhatIfagainst a real subscription/SP to confirm the planned actions look rightContributorlands at RG scope only-IncludeSubscriptionScope -SkipAdoGroupMembershipfor the e2e identity, confirm subscription-scopeContributor