Skip to content

Fix TypeError crash in --thorough mode on V1-3 Z-machine games #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aliciusschroeder wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix TypeError crash in --thorough mode on V1-3 Z-machine games #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions zwalker/zmachine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2011,11 +2011,17 @@ def handle_char(input_text: str):
# Extended
elif name == "save":
# For automated walking, always succeed
self.set_variable(store_var, 1)
if store_var is not None:
self.set_variable(store_var, 1) # V4+
elif branch is not None:
self._do_branch(True, branch) # V1-3: branch on success

elif name == "restore":
# For automated walking, always fail (no saved game to restore)
self.set_variable(store_var, 0)
if store_var is not None:
self.set_variable(store_var, 0) # V4+
elif branch is not None:
self._do_branch(False, branch) # V1-3: don't branch (failure)

elif name == "save_undo":
self.set_variable(store_var, 1) # Success (but we don't actually save)
Expand Down