Open
Conversation
rand::thread_rng() has been renamed rand::rng(), so let’s fix that deprecation warning while we’re at it.
I’m not sure if we should add something to the ReceiverVideoConstraints message, but for now let’s set the two new fields to None.
|
jitsi switched signalling from collibri to sth else, that's why it does not work with meet.jit.si. Maybe that's the issue. Alex |
Contributor
|
The colibri singaling is still used but it was switch from the websocket channel to the webrtc datachannel in default configuration. As discuted in the issue : #109 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of it was quite mechanical, or even required no change at all.
The xmpp.rs crates have had a lot of changes since the last time, so I’m leaving that for a different PR. The main change being the switch from custom macros to xso procedural macros.
gst-meet doesn’t work with current Jitsi Meet atm, I’ll try to debug that at some point.