-
Notifications
You must be signed in to change notification settings - Fork 10
Added docs for custom events. #1633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -109,7 +109,7 @@ _Example: Adding metric to a category._ | |||||
|
|
||||||
| ### Step 5 – Select metric type | ||||||
|
|
||||||
| The metric type determines how you will construct your metric in your analytics platform or raw database. The available metrics types in Avo are _Funnel_, _Segmentation_, _Retention_ and _Proportion_. Read about their unique capabilities in our [Metrics page](/data-design/avo-tracking-plan/metrics). | ||||||
| The metric type determines how you will construct your metric in your analytics platform or raw database. The available metrics types in Avo are _Funnel_, _Segmentation_, _Retention_, _Proportion_, and _[Custom Event](/data-design/avo-tracking-plan/metrics#custom-events)_. Read about their unique capabilities in our [Metrics page](/data-design/avo-tracking-plan/metrics). | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Inconsistent metric type name: "Segmentation" vs. "Event Segmentation". This line lists the type as Segmentation, but the metrics page (the canonical reference) consistently calls it Event Segmentation (see the table and the step-by-step list in Proposed fix-The metric type determines how you will construct your metric in your analytics platform or raw database. The available metrics types in Avo are _Funnel_, _Segmentation_, _Retention_, _Proportion_, and _[Custom Event](/data-design/avo-tracking-plan/metrics#custom-events)_. Read about their unique capabilities in our [Metrics page](/data-design/avo-tracking-plan/metrics).
+The metric type determines how you will construct your metric in your analytics platform or raw database. The available metrics types in Avo are _Funnel_, _Event Segmentation_, _Retention_, _Proportion_, and _[Custom Event](/data-design/avo-tracking-plan/metrics#custom-events)_. Read about their unique capabilities in our [Metrics page](/data-design/avo-tracking-plan/metrics).📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
|
|
||||||
| <video | ||||||
| controls | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ambiguous use of "metric" in nesting rules may confuse readers.
Lines 72–73 say a Custom Event "cannot itself be nested inside another metric" and "is already nested inside another metric." Since line 71 defines nesting as being "added as items inside other metrics" (of any type), a literal reading of line 72 implies a composite Custom Event can't be used in a Funnel or Segmentation either — which contradicts the purpose of Custom Events.
If the one-level restriction only applies to Custom-Event-inside-Custom-Event depth (i.e., a composite CE can still be added to a Funnel), replace "another metric" with "another Custom Event" in both bullets to remove the ambiguity.
Proposed fix
🤖 Prompt for AI Agents