Allow retries for all major remote copy methods#167
Open
pevogam wants to merge 2 commits into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pevogam
force-pushed
the
remote-copy-retries
branch
4 times, most recently
from
9d5a509 to
adb7ef2
Compare
For certain categories of transient network errors allowing more resilience to remote copy operations is highly desirable where the copy should at least be retried a configurable number of times in (standard) one second intervals. Add corresponding test contract and reorder the test cases in sync with the original API funtions ordering. Signed-off-by: Plamen Dimitrov <plamen.dimitrov@intra2net.com>
pevogam
force-pushed
the
remote-copy-retries
branch
from
adb7ef2 to
5ff5046
Compare
Signed-off-by: Plamen Dimitrov <plamen.dimitrov@intra2net.com>
pevogam
force-pushed
the
remote-copy-retries
branch
from
e994271 to
c7e9319
Compare
Contributor
Author
|
@ldoktor While the first commit is final on my side, I added a second commit here which is questionable - it adds retries to some more exotic copy methods and I would like to hear your opinion about it. Do you think such extension is worth it? It will be much harder to test at least in one case it indents a long and complex function into a loop and try block which might have a better way of achieving, e.g. via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #166.