fix: resolve test fixture paths via build.Import instead of $GOPATH/src#50
Open
jonbaldie wants to merge 2 commits into
Open
fix: resolve test fixture paths via build.Import instead of $GOPATH/src#50jonbaldie wants to merge 2 commits into
jonbaldie wants to merge 2 commits into
Conversation
Tests built expected file paths as os.Getenv("GOPATH")+"/src/..." which
fails in module mode where packages live outside \$GOPATH/src; they now
use build.Import to find the actual package directory, and the wildcard
package resolution tests (which rely on GOPATH SrcDirs walking) are
skipped in module mode with a clear message.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ipIfNoWildcard Two functions called fixtureDir(t) at the outer scope even though the resolved path was only used inside wildcard subtests; if package resolution failed it skipped the whole test including file/directory cases that never needed it. Also replaced the FilesOfArgs probe in skipIfNoWildcard with a SrcDirs walk to avoid the spurious warning printed to stderr on every module-mode run. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The importing tests built expected file paths as
os.Getenv("GOPATH") + "/src/...", which fails in module mode where packages are not stored under$GOPATH/src; they now usebuild.Importto find the real package directory on the current machine, and wildcard package resolution tests (which depend on GOPATH SrcDirs walking) are skipped in module mode with a clear explanation.