fix: set types.Config.Sizes to prevent nil pointer panic on Go 1.21+#49
Open
jonbaldie wants to merge 2 commits into
Open
fix: set types.Config.Sizes to prevent nil pointer panic on Go 1.21+#49jonbaldie wants to merge 2 commits into
jonbaldie wants to merge 2 commits into
Conversation
Without Sizes set in the loader's TypeChecker, go/types.(*StdSizes).Sizeof dereferences a nil pointer on Go 1.21 and later, crashing go-mutesting immediately on any project. Closes avito-tech#37. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
types.SizesFor returns nil for unrecognised compiler/arch combinations; setting Sizes to nil would reproduce the same crash we are trying to prevent, so the value is only assigned when it is non-nil. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.21+ requires
types.Config.Sizesto be set; without it,go/types.(*StdSizes).Sizeofdereferences a nil pointer and crashes go-mutesting immediately, which is the root cause described in #37 and reported again in #44.Closes #37.