fix: apply exec-timeout to external --exec command via CommandContext#47
Closed
jonbaldie wants to merge 1 commit into
Closed
fix: apply exec-timeout to external --exec command via CommandContext#47jonbaldie wants to merge 1 commit into
jonbaldie wants to merge 1 commit into
Conversation
The external --exec path called Start()+Wait() with no timeout, so a hung test script would block go-mutesting forever; now it uses exec.CommandContext and returns exit code 2 (skip) when the deadline is exceeded. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Author
|
Superseded by #52 which combines this with the panic fixes and also handles the Timeout=0 edge case and tmpDir leak. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The external
--execpath usedStart()+Wait()with a// TODO timeout herecomment and no actual timeout, so a hung test script would block go-mutesting forever; this replaces it withexec.CommandContextso the process is killed after--exec-timeoutseconds, returning exit code 2 (skip) to the caller.