fix: strip one char from wildcard --disable pattern, not two#45
Open
jonbaldie wants to merge 2 commits into
Open
fix: strip one char from wildcard --disable pattern, not two#45jonbaldie wants to merge 2 commits into
jonbaldie wants to merge 2 commits into
Conversation
The --disable flag trims d[:len(d)-2] when the pattern ends with '*',
but '*' is only one character, so short names like 'branch*' produce
the wrong prefix ('branc' instead of 'branch').
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Extracts the pattern-matching logic into a named function so it can be tested directly. Adds TestMutatorDisabled which pins the off-by-one bug: with len(d)-2, a two-char pattern like "b*" produced an empty prefix and disabled every mutator; len(d)-1 correctly extracts "b". Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--disableflag stripsd[:len(d)-2]when a pattern ends with*, but*is only one character, so a pattern likebranch*produces the prefixbrancinstead ofbranchand matches nothing.