Skip to content

adds twitter widget#23

Closed
locks wants to merge 1 commit into
avdi:masterfrom
locks:twitter-widget
Closed

adds twitter widget#23
locks wants to merge 1 commit into
avdi:masterfrom
locks:twitter-widget

Conversation

@locks

@locks locks commented May 14, 2013

Copy link
Copy Markdown
Contributor

Hi,

I just had an idea and thought I'd cook up a small PR to open up the discussion, instead of just opening an Issue.
I think it would be added value to have a small Twitter widget that shows #pairwithme tweets, so you can instantly see if anyone's available at the moment.

Never mind the style mangling, just want to gauge interest :)

Here's a screenshot of my change:
Twitter Widget

@chrisradford

Copy link
Copy Markdown
Collaborator

I'm not opposed to it, generally the Twitter widgets look pretty awful but the colors are close to the site here and it does provide a good overview of people currently talking about #pairwithme

A couple of changes you'll want to make though:

It's @avdi's call but my opinion would be that with the above changes it'll be a decent addition to the site.

@avdi

avdi commented May 17, 2013

Copy link
Copy Markdown
Owner

I agree with @chrisradford. I was also thinking about moving the widget down into the sidebar of the "resources" section rather than in the top section.

@locks

locks commented May 17, 2013

Copy link
Copy Markdown
Contributor Author

@avdi I considered if it shouldn't go into the resources section, but I found it more advantageous to have the tweets "above the fold".

Thank you both for the feedback, I'll implement the suggestions in the next couple days.

@avdi

avdi commented May 29, 2013

Copy link
Copy Markdown
Owner

Looking forward to it!

@joonty

joonty commented Jun 26, 2013

Copy link
Copy Markdown
Collaborator

@locks any more on this? Thanks.

@bf4

bf4 commented Jun 26, 2013

Copy link
Copy Markdown
Collaborator

I like this idea. Can it have a title like 'Who's pairing?' This might be a good use case to move in some the https://github.com/rubyrogues/rubyfriends/blob/master/lib/twitter_search.rb twitter search code (which I'd like to make into an engine), so that it pulls the tweets from a db and gives us more control over how we surface it and performance

and then if we have users sharing their twitters handles and logging in.. could be pretty cool.. rubyrogues/ppwm-matcher#47

@chrisradford

Copy link
Copy Markdown
Collaborator

@bf4 does that code work with the V1.1 API?

Also, would having the feed read from the Database not remove much of the value of seeing a realtime list of "Who's Pairing?"…

@bf4

bf4 commented Jul 1, 2013

Copy link
Copy Markdown
Collaborator

@chrisradford it works with the latest api, see the twitter gem it uses. as for realtime.. sure, I suppose, or we use the streaming api or be satisfied with an update as frequent as we update the tweets. This would be a step 2 anyway as, unless you're going to copy and paste, the twitter stuff in rubyfriends isn't fully abstracted into an engine, yet.

@locks

locks commented Jul 2, 2013

Copy link
Copy Markdown
Contributor Author

my bad on the radio silence, I've been a tad busy with exams/work.
@bf4 my problem is in trusting the Twitter API 👅 so your idea would replace the widget?

@bf4

bf4 commented Jul 2, 2013

Copy link
Copy Markdown
Collaborator

@locks it could, sure, in the sense that we would build the widget with data from the db rather than the twitter js api.

@bf4

bf4 commented Aug 6, 2013

Copy link
Copy Markdown
Collaborator

Hey, just saw this, kind of interesting: yui3 tweets though there might actually be a newer version of the repo somewhere

@bf4

bf4 commented Oct 17, 2013

Copy link
Copy Markdown
Collaborator

Should we move forward on this PR or close it?

@locks

locks commented Oct 17, 2013

Copy link
Copy Markdown
Contributor Author

sorry @bf4. as you can see from my profile, I still haven't quite gotten back on the proverbial horse.
I can carve up some time this week to update the PR if it's still relevant, otherwise you can close it.

thanks for the patience.

@bf4

bf4 commented Oct 17, 2013

Copy link
Copy Markdown
Collaborator

@locks No need to discuss horses; I don't think there was any resolution of the desired implementation.

@chrisradford

Copy link
Copy Markdown
Collaborator

I'm in favour of the option without the twitter embed widget, since it's not particularly pretty or customisable (and I believe linked to a single username).

@locks if you're still up for building this out it would be nice addition, I'd personally use the twitter gem but go for whatever works for you. Regarding location on the page; that can change, go for whichever and we can move it later if needed.

@bf4 anything I've missed? And yes, it'd be good to get this closed off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants