Fix: pass string to draft_joke (use joke.joke)#2
Open
tanvircr7 wants to merge 1 commit intoavbiswas:mainfrom
Open
Fix: pass string to draft_joke (use joke.joke)#2tanvircr7 wants to merge 1 commit intoavbiswas:mainfrom
tanvircr7 wants to merge 1 commit intoavbiswas:mainfrom
Conversation
should be draft_joke = joke.joke in the loop. The current code is relying on DSPy’s auto coercion, but that’s brittle and confusing. Explicitly unwrapping (.joke) makes the flow clearer and type-safe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: pass string to
draft_joke(usejoke.joke)Summary
This PR fixes a small type/semantics issue in
IterativeJokeGenerator.forward.Previously, the loop set:
where joke is a DSPy Prediction object. This relied on implicit coercion when passing draft_joke into the next call.
Now it explicitly sets:
so draft_joke is a plain string, consistent with the IdeaToJoke signature
Why
Avoids brittle realince on implicit type coercion