Closed
Conversation
Member
|
This looks good except that last part. Seems like blocking shouldn't undo/delete the bookmarks/interactions/mentions, but rather just hide them (as the other changes handle)? I honestly don't know what Mastodon does, but seems like it shouldn't be destructive, at least not immediately. |
Collaborator
Author
|
close as I have additional fix on this in my upcoming bundled pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there are a few loopholes about block, a blocked user may still see/interact with posts they should not be able to, this PR hopefully fixes most if not all of them.
Updated area:
PostQuerySet.visible_to