Closed
Conversation
c12aa62 to
06b4ddb
Compare
06b4ddb to
982f2bf
Compare
dcwatson
reviewed
Jun 24, 2024
| ) | ||
| TimelineEvent.objects.filter( | ||
| identity=self.post.author, | ||
| type__in=[TimelineEvent.Types.post, TimelineEvent.Types.boost], |
Member
|
Collaborator
Author
yep, just to make sure the author sees change immediately in case stator does not catch up fast enough; I added a comment for this but I'm ok to remove this hackish delete if you prefer.
Sorry, accidentally dropped that when copy paste from my production branch, should be good now |
Collaborator
Author
|
I'll bundle this in my upcoming pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves most delete logic into Post.handle_deleted, and addresses the following issues of previous implementation:
For the last issue, this PR only UNDO the boost, but not forward the DELETE activity to remote instances bc it's too much work. Although both were done in Mastodon.