CP-12886 - Balance Service follow ups#3442
Merged
bogdandobritoiu merged 38 commits intomainfrom Jan 27, 2026
Merged
Conversation
B0Y3R-AVA
reviewed
Jan 22, 2026
B0Y3R-AVA
reviewed
Jan 22, 2026
B0Y3R-AVA
reviewed
Jan 22, 2026
| - BranchSDK (= 3.12.2) | ||
| - React-Core | ||
| - react-native-compat (2.23.0): | ||
| - react-native-compat (2.11.0): |
Contributor
There was a problem hiding this comment.
reason we moved backwards with this package?
Contributor
Author
There was a problem hiding this comment.
I've reverted it.
B0Y3R-AVA
reviewed
Jan 22, 2026
Contributor
B0Y3R-AVA
left a comment
There was a problem hiding this comment.
Great work! few small nitpicks and questions
B0Y3R-AVA
previously approved these changes
Jan 23, 2026
atn4z7
reviewed
Jan 26, 2026
atn4z7
reviewed
Jan 26, 2026
atn4z7
reviewed
Jan 26, 2026
atn4z7
reviewed
Jan 26, 2026
atn4z7
reviewed
Jan 26, 2026
atn4z7
reviewed
Jan 26, 2026
atn4z7
reviewed
Jan 26, 2026
atn4z7
reviewed
Jan 26, 2026
atn4z7
reviewed
Jan 26, 2026
atn4z7
reviewed
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ticket: CP-12886
Ticket: CP-13100
Refactored the balance loading logic into a single request to get all accounts and reuse that hook everywhere for the wallet overview screen.
useAllBalancesfor requesting all balancesAccountBalanceandWalletBalanceto load data fromuseAllBalancesScreenshots/Videos
Screen.Recording.2025-12-17.at.21.50.40.mov
Error case
Simulator.Screen.Recording.-.26.-.2025-12-17.at.23.40.33.mov
Testing
iOS - 7174
Android - 7175
Dev Testing (if applicable)
To properly test you need wallets with many accounts. 50+ accounts would be best to fully test this.
Checklist
Please check all that apply (if applicable)