feat: Automatically select new dataset upon creation#348
Open
artkuo wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically selects the newly created dataset once a user adds a new dataset. If the user adds multiple datasets, the first of the newly added datasets is automatically selected.
Motivation
I often found myself accidentally adding new data points to the previously active dataset rather than the newly created one. Automatically switching the selection to the new dataset matches user expectation and makes the workflow more ergonomic.
Technical Changes
In
datasetManagement.js:wpd.tree.refreshPreservingSelection()inaddSingleDataset()with a call towpd.tree.refresh()andwpd.tree.selectPath()targeting the new dataset.addMultipleDatasets()to track the first new dataset that gets created, and select its path after the tree is refreshed.Verification (Manual Testing)
I manually tested the behavior locally in the UI: