自環境でビルドが通らない不具合を修正 #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
返信遅くなりました🙇 ae39b77 については、元のままで合っています。legacy ブランチで改名前のプロジェクトを管理しているので、そちらをビルドするか、もしくは Releases から それ以外の修正は仰る通り不具合です。修正ありがとうございます。マージするので、↑のコミットだけ revert していただけますでしょうか。 |
automatic9045
pushed a commit
that referenced
this pull request
Jan 2, 2025
Owner
|
そのままsquash mergeした上、こちらでrebaseしました🙇 |
Contributor
Author
|
#45 も立ってましたし2件分けるべきでしたね。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
おま環かもしれないですが、手元の環境ではこの修正でビルドが通るようになったので報告がてらプルリクを立てておきます。
namespaceの変え忘れで死んでいたみたいで、reponameは多分変えなくてもビルド通る気がします。
コードをしっかり読んだわけではなくエラーを見て適当に置換しただけなので、意図と違う修正をしていたらすみません。