fix: use built-in token for rolling PR workflow#105
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR hardens the rolling PR workflow with improved safety and token handling, while expanding release branch strategy documentation. The workflow now uses the built-in GitHub token, strict shell options, and safer PR detection logic with guards for existing PRs and commits ahead of main. Documentation clarifies that main is the canonical release branch and short-lived topic branches should be used for focused work. ChangesRolling PR Workflow and Release Strategy
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the release contract documentation in docs/release-contract.md to clarify that main is the expected branch for long-lived production checkouts. It also advises using short-lived drogo/ branches for focused changes and returning the production checkout to main after merging, rather than maintaining a long-lived drogo/prod-rlmx branch. There are no review comments, and I have no additional feedback to provide.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7cb8be88a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| GH_TOKEN: ${{ secrets.RELEASE_PLEASE_TOKEN }} | ||
| # Use the built-in workflow token. A stale custom token should not make | ||
| # the release-boundary helper fail with 401 on scheduled runs. | ||
| GH_TOKEN: ${{ github.token }} |
There was a problem hiding this comment.
Use an app/PAT token so PR CI runs automatically
For the scheduled path that creates a new dev -> main PR, replacing the PAT with ${{ github.token }} means the repository's pull_request workflows (.github/workflows/ci.yml and commitlint.yml, both filtered to main/dev) will not run automatically; GitHub documents that PRs created/updated with GITHUB_TOKEN put resulting pull_request runs in an approval-required state, while a GitHub App token or PAT lets them run automatically (https://docs.github.com/en/actions/how-tos/write-workflows/choose-when-workflows-run/trigger-a-workflow#triggering-a-workflow-from-a-workflow). That breaks the rolling PR's intended unattended check/ready state after creation until someone manually approves the workflows.
Useful? React with 👍 / 👎.
Summary
RELEASE_PLEASE_TOKENto${{ github.token }}dev->mainPR already exists or whendevis not aheadmain; source work uses short-liveddrogo/<topic>branchesVerification
.github/workflows/rolling-pr.ymlbash -nnpm run checknpm test— 377 passing, 0 failingSummary by CodeRabbit
Documentation
Chores