-
Notifications
You must be signed in to change notification settings - Fork 34
[WIP] [New Model] GRANDE #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Heyho @s-marton, great work on the PR, this looks great and awesome results! I will try to get back to you ASAP and start a run on my end so I can run on all folds/splits afterwards. I kindly ask for some patience, as the winter break begins on Wednesday, and it might take me a bit longer to take a closer look. |
|
One initial thought: I see a fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Hey, no problem at all! Take your time, and enjoy the winter break. Looking forward to hearing from you whenever you get a chance.
Regarding your question on |
Ah, gotcha! I should read the paper as well! :) |
|
It seems that the multi-class plot above is in fact the regression plot and vice versa. So GRANDE's weakness is regression tasks, not multi-class tasks. |
I just double-checked the subsets, and you’re absolutely right, the issue is with regression. That also makes more sense conceptually and gives a clearer direction for how we might improve the results. I’ll look into it and hopefully be able to push an update soon. |
|
Heyho, here are some results from my initial evaluation on TabArena-Lite with 50 configs (for now). The results seem a bit worse, but that's reasonable given it is less HPO and we now force early stopping after 1 hour. Yet, there seems to be a problem related to the default performance for regression. I am not quite sure what triggered this change. And will have to investigate. In general, from my work on the refactor, it seems like it would be great to refactor the PR such that we pip install GRANDE from the official repository so it might function as a standalone package. @s-marton is this something you are working towards?
|
|
Hi @LennartPurucker, The default performance for regression, however, is surprising. I will take a look at this as well. The GRANDE repo is currently a bit behind, but I am planning to update it soon, so it should be possible to refactor the PR to use a pip install. I will take care of this shortly. |
|
Great to hear @s-marton! Let me know once I should take another look. After ICML, I should also have enough compute to run more configs! |




Add GRANDE method for TabArena benchmarking
Description
This PR introduces GRANDE, a novel method for learning axis-aligned decision tree ensembles with gradient descent, into the TabArena benchmark.
Changes included
tabarena/tabarena/benchmark/models/ag/grande/tabarena/tabarena/models/grande/model_registry.pyandmodels/utils.pyfiles to include GRANDEtst/benchmark/models/test_grande.pyto verify correct integration and basic functionalityEvaluation
Figure 1: GRANDE results on TabArena folds 0, 1, and 2.
Figure 2a: GRANDE binary classification results on TabArena folds 0, 1, and 2.
Figure 2b: GRANDE regression results on TabArena folds 0, 1, and 2.
Figure 2c: GRANDE multi-class classification results on TabArena folds 0, 1, and 2.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.