fix: [BUG] Internal Server Errors still shows success toast (closes #3302)#1
Open
autodev-botbit wants to merge 1 commit into
Open
fix: [BUG] Internal Server Errors still shows success toast (closes #3302)#1autodev-botbit wants to merge 1 commit into
autodev-botbit wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for formbricks#3302
Summary
The bug occurs when the backend returns a 200 status code with a serverError field in the response, but the frontend doesn't check for this field and incorrectly shows a success toast. The fix involves modifying the frontend code to check for serverError in the response and throw an error if present.
Changes
Testing
npm test: FAILED (may need setup)
This PR was automatically generated to address the bounty issue formbricks#3302.
Please review the changes carefully before merging.