-
Notifications
You must be signed in to change notification settings - Fork 2
DYN-10011: Return runtime concrete type for types implementing .NET interfaces #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DYN-10011: Return runtime concrete type for types implementing .NET interfaces #5
Conversation
|
Is it feasible to add a test for this? |
I know how to add a test for this in Dynamo. Will explore how I can add a test to this project. |
RobertGlobant20
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
twastvedt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like test CI needs some attention, but if this runs locally, looks good to me.
|
|
|
Closing in favor of #6 |
What does this implement/fix? Explain your changes.
Background: When a .NET method returns a concrete type that implements an interface, e.g.
IDisposable, pythonnet incorrectly resolves the object as the interface type instead of the concrete type. This prevents access to the concrete type's members and breaks common patterns using Python's with statement for resource management with IDisposable types.This PR attempts to fix the above issue.
Does this close any currently open issues?
...
Any other comments?
Reviewers:
@zeusongit
@twastvedt
@zavub
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG