Update ACES2 CPU non-SIMD path #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lidity of the scalar math. For SIMD we need to do implement run-time switching logic too. - Slight improvements to the unit tests so that we print out the computed error metric as well as the actual and expected values. Helps to see the magnitude of the error. - FixedFunctionOpCPU and BuiltinTransform tests now produce error lines with the same structure & syntax, including the computed error. - Updated the expected values for ACES2 tests with the values the new optimized code produces, this makes all of the of CPU tests pass now. - For ACES2 ops and builtin transforms, the error threshold is increased to 1e-4 - added few, temporary code snippets that dumps the currently produced results, making it easier to update the golden values if needed again. Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
Signed-off-by: cuneyt.ozdas <cuneyt.ozdas@autodesk.com>
doug-walker
approved these changes
Feb 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commenting out the ACES2 SIMD implementation for now to focus on validity of the scalar math. For SIMD we need to implement run-time switching logic too.
Slight improvements to the unit tests so that we print out the computed error metric as well as the actual and expected values. Helps to see the magnitude of the error.
FixedFunctionOpCPU and BuiltinTransform tests now produce error lines with the same structure & syntax, including the computed error.
Updated the expected values for ACES2 tests with the values the new optimized code produces, this makes all of the of CPU tests pass now.
For ACES2 ops and builtin transforms, the error threshold is increased to 1e-4
added few, temporary code snippets that dumps the currently produced results, making it easier to update the golden values if needed again.